Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds JsonNodeReader #1065

Merged
merged 5 commits into from
Jun 14, 2024
Merged

Adds JsonNodeReader #1065

merged 5 commits into from
Jun 14, 2024

Conversation

justin-tay
Copy link
Contributor

@justin-tay justin-tay commented Jun 14, 2024

Adds an JsonNodeReader interface to abstract out the logic for reading content into a JsonNode.

This will make it easier to customize how the reading is done with a custom implementation. This also potentially allows easier reuse of the logic of reading location aware nodes by trying to decouple this from the JsonSchemaFactory.

This deprecates the setting of jsonMapper and yamlMapper on the JsonSchemaFactory in favor of the jsonNodeReader.

@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 64.28571% with 15 lines in your changes missing coverage. Please review.

Project coverage is 78.68%. Comparing base (48ca3c2) to head (8953fe8).
Report is 31 commits behind head on master.

Files Patch % Lines
...nt/schema/serialization/DefaultJsonNodeReader.java 60.60% 9 Missing and 4 partials ⚠️
...n/java/com/networknt/schema/JsonSchemaFactory.java 75.00% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1065      +/-   ##
============================================
- Coverage     78.90%   78.68%   -0.22%     
- Complexity     1965     2053      +88     
============================================
  Files           172      198      +26     
  Lines          6352     6635     +283     
  Branches       1255     1249       -6     
============================================
+ Hits           5012     5221     +209     
- Misses          867      936      +69     
- Partials        473      478       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justin-tay justin-tay changed the title Adds ObjectReader Adds JsonNodeReader Jun 14, 2024
@stevehu stevehu merged commit 45c0b8f into networknt:master Jun 14, 2024
4 checks passed
@justin-tay justin-tay deleted the objectreader branch July 2, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants