Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to make more fields final #1060

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

justin-tay
Copy link
Contributor

Refactor to make more fields final to ensure they aren't inadvertently changed and possibly improve performance marginally.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 90.38462% with 10 lines in your changes missing coverage. Please review.

Project coverage is 78.88%. Comparing base (48ca3c2) to head (85246f1).
Report is 25 commits behind head on master.

Files Patch % Lines
...com/networknt/schema/ValidationMessageHandler.java 76.92% 3 Missing and 3 partials ⚠️
...n/java/com/networknt/schema/MaxItemsValidator.java 50.00% 3 Missing ⚠️
.../java/com/networknt/schema/MaxLengthValidator.java 75.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1060      +/-   ##
============================================
- Coverage     78.90%   78.88%   -0.03%     
- Complexity     1965     2018      +53     
============================================
  Files           172      189      +17     
  Lines          6352     6530     +178     
  Branches       1255     1248       -7     
============================================
+ Hits           5012     5151     +139     
- Misses          867      907      +40     
+ Partials        473      472       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehu stevehu merged commit 4e5a808 into networknt:master Jun 13, 2024
4 checks passed
@justin-tay justin-tay deleted the final branch June 13, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants