Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GraalJS regular expression and factory implementation #1058

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

justin-tay
Copy link
Contributor

This adds the optional usage of GraalJS as the regular expression evaluation engine. This makes it somewhat easier to verify that the Joni regular expression implementation is correct.

This also fixes the JoniRegularExpression implementation as the Syntax.ECMAScript wasn't accepting certain valid regular expressions by configuring a custom Syntax with additional options

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 93.22034% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.86%. Comparing base (48ca3c2) to head (3e41dee).
Report is 21 commits behind head on master.

Files Patch % Lines
...hema/regex/ECMAScriptRegularExpressionFactory.java 76.92% 1 Missing and 2 partials ⚠️
.../networknt/schema/regex/GraalJSContextFactory.java 75.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1058      +/-   ##
============================================
- Coverage     78.90%   78.86%   -0.05%     
- Complexity     1965     2061      +96     
============================================
  Files           172      198      +26     
  Lines          6352     6651     +299     
  Branches       1255     1261       +6     
============================================
+ Hits           5012     5245     +233     
- Misses          867      929      +62     
- Partials        473      477       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehu stevehu merged commit 3daa5bc into networknt:master Jun 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants