Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize getValueNodeType #1048

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Optimize getValueNodeType #1048

merged 1 commit into from
Jun 6, 2024

Conversation

justin-tay
Copy link
Contributor

Optimized the performance of the type validator by refactoring getValueNodeType.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.72%. Comparing base (48ca3c2) to head (9b6de48).
Report is 17 commits behind head on master.

Files Patch % Lines
...rc/main/java/com/networknt/schema/TypeFactory.java 91.66% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1048      +/-   ##
============================================
- Coverage     78.90%   78.72%   -0.19%     
- Complexity     1965     2030      +65     
============================================
  Files           172      191      +19     
  Lines          6352     6589     +237     
  Branches       1255     1260       +5     
============================================
+ Hits           5012     5187     +175     
- Misses          867      927      +60     
- Partials        473      475       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehu stevehu merged commit 7728325 into networknt:master Jun 6, 2024
4 checks passed
@justin-tay justin-tay deleted the type branch June 12, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants