Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tracking of json node location information #1046

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

justin-tay
Copy link
Contributor

This allows easier tracking of the json node location information such as the line and column number by providing a default implementation that can be configured.

This is not configured by default as it will adversely affect performance.

@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 47.71242% with 80 lines in your changes missing coverage. Please review.

Project coverage is 78.65%. Comparing base (48ca3c2) to head (5f896a3).
Report is 16 commits behind head on master.

Files Patch % Lines
...ma/serialization/node/LocationJsonNodeFactory.java 35.71% 17 Missing and 1 partial ⚠️
...ain/java/com/networknt/schema/utils/JsonNodes.java 57.89% 5 Missing and 3 partials ⚠️
...in/java/com/networknt/schema/JsonNodeLocation.java 0.00% 7 Missing ⚠️
...erialization/node/JsonLocationAwareBinaryNode.java 0.00% 7 Missing ⚠️
...n/java/com/networknt/schema/JsonSchemaFactory.java 76.00% 4 Missing and 2 partials ⚠️
...serialization/node/JsonLocationAwareArrayNode.java 40.00% 6 Missing ⚠️
...lization/node/JsonLocationAwareBigIntegerNode.java 0.00% 4 Missing ⚠️
...erialization/node/JsonLocationAwareDoubleNode.java 0.00% 4 Missing ⚠️
...serialization/node/JsonLocationAwareFloatNode.java 0.00% 4 Missing ⚠️
.../serialization/node/JsonLocationAwareLongNode.java 0.00% 4 Missing ⚠️
... and 4 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1046      +/-   ##
============================================
- Coverage     78.90%   78.65%   -0.26%     
- Complexity     1965     2031      +66     
============================================
  Files           172      191      +19     
  Lines          6352     6600     +248     
  Branches       1255     1267      +12     
============================================
+ Hits           5012     5191     +179     
- Misses          867      930      +63     
- Partials        473      479       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehu stevehu merged commit 880329b into networknt:master Jun 5, 2024
4 checks passed
@justin-tay justin-tay deleted the location branch June 13, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants