Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customization of assertion for outputunit #1033

Merged
merged 1 commit into from
May 1, 2024

Conversation

justin-tay
Copy link
Contributor

Closes #1030

This adds a constructor argument for OutputFormat.Hierarchical and OutputFormat.List to add a function to allow mapping of the ValidationMessage to an Object. This allows the message to be customized or allows the ValidationMessage to be passed through as is if the identity function is used.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 96.55172% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 79.18%. Comparing base (48ca3c2) to head (99d510a).
Report is 10 commits behind head on master.

Files Patch % Lines
...va/com/networknt/schema/output/OutputUnitData.java 80.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1033      +/-   ##
============================================
+ Coverage     78.90%   79.18%   +0.27%     
- Complexity     1965     1989      +24     
============================================
  Files           172      174       +2     
  Lines          6352     6437      +85     
  Branches       1255     1261       +6     
============================================
+ Hits           5012     5097      +85     
+ Misses          867      864       -3     
- Partials        473      476       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehu stevehu merged commit bc61ef3 into networknt:master May 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve outputUnits with all assertion fields
3 participants