Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix walk for if validator with validation #1010

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

justin-tay
Copy link
Contributor

Closes #1009

Previously with the validate schema option enabled, the walk would delegate to validate. But calling validate on the schemas will not walk the schema.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 78.90%. Comparing base (fbf11c3) to head (7759a24).
Report is 1 commits behind head on master.

Files Patch % Lines
...rc/main/java/com/networknt/schema/IfValidator.java 73.33% 0 Missing and 4 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1010      +/-   ##
============================================
+ Coverage     78.80%   78.90%   +0.10%     
- Complexity     1960     1965       +5     
============================================
  Files           172      172              
  Lines          6345     6352       +7     
  Branches       1253     1255       +2     
============================================
+ Hits           5000     5012      +12     
+ Misses          876      867       -9     
- Partials        469      473       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehu stevehu merged commit 48ca3c2 into networknt:master Apr 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyword Walker not walking root of then/else
3 participants