Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPE due to concurrency bug #392

Closed
Keymaster65 opened this issue Mar 30, 2021 · 4 comments
Closed

NPE due to concurrency bug #392

Keymaster65 opened this issue Mar 30, 2021 · 4 comments

Comments

@Keymaster65
Copy link
Contributor

In high load tests, we sometimes get this bug:
java.lang.NullPointerException: null
at com.networknt.schema.JsonSchemaRef.validate(JsonSchemaRef.java:49)
at com.networknt.schema.RefValidator.validate(RefValidator.java:138)
at com.networknt.schema.JsonSchema.validate(JsonSchema.java:224)
at com.networknt.schema.AllOfValidator.validate(AllOfValidator.java:44)
at com.networknt.schema.JsonSchema.validate(JsonSchema.java:224)
at com.networknt.schema.JsonSchemaRef.validate(JsonSchemaRef.java:49)
at com.networknt.schema.RefValidator.validate(RefValidator.java:138)
at com.networknt.schema.JsonSchema.validate(JsonSchema.java:224)
at com.networknt.schema.ItemsValidator.doValidate(ItemsValidator.java:93)
at com.networknt.schema.ItemsValidator.validate(ItemsValidator.java:80)
at com.networknt.schema.JsonSchema.validate(JsonSchema.java:224)
at com.networknt.schema.PropertiesValidator.validate(PropertiesValidator.java:75)
at com.networknt.schema.JsonSchema.validate(JsonSchema.java:224)
at com.networknt.schema.JsonSchemaRef.validate(JsonSchemaRef.java:49)
at com.networknt.schema.RefValidator.validate(RefValidator.java:138)
at com.networknt.schema.JsonSchema.validate(JsonSchema.java:224)
at com.networknt.schema.AllOfValidator.validate(AllOfValidator.java:44)
at com.networknt.schema.JsonSchema.validate(JsonSchema.java:224)
at com.networknt.schema.JsonSchemaRef.validate(JsonSchemaRef.java:49)
at com.networknt.schema.RefValidator.validate(RefValidator.java:138)
at com.networknt.schema.JsonSchema.validate(JsonSchema.java:224)
at com.networknt.schema.PropertiesValidator.validate(PropertiesValidator.java:75)
at com.networknt.schema.JsonSchema.validate(JsonSchema.java:224)
at com.networknt.schema.JsonSchemaRef.validate(JsonSchemaRef.java:49)
at com.networknt.schema.RefValidator.validate(RefValidator.java:138)
at com.networknt.schema.JsonSchema.validate(JsonSchema.java:224)
at com.networknt.schema.ItemsValidator.doValidate(ItemsValidator.java:93)
at com.networknt.schema.ItemsValidator.validate(ItemsValidator.java:80)
at com.networknt.schema.JsonSchema.validate(JsonSchema.java:224)
at com.networknt.schema.PropertiesValidator.validate(PropertiesValidator.java:75)
at com.networknt.schema.JsonSchema.validate(JsonSchema.java:224)
at com.networknt.schema.BaseJsonValidator.validate(BaseJsonValidator.java:101
@Keymaster65
Copy link
Contributor Author

I'll try to add a PR.

@stevehu
Copy link
Contributor

stevehu commented Mar 30, 2021

@Keymaster65 We have another issue opened that is concurrency related. I don't know if they are the same root cause. The NPE is thrown from two different locations. Just for your reference.

#335

@Keymaster65
Copy link
Contributor Author

I think #335 is another bug.

@stevehu
Copy link
Contributor

stevehu commented Mar 30, 2021

Thanks for the confirmation. I assume it is a different defect as the NPE is thrown from two different locations.

stevehu pushed a commit that referenced this issue Mar 30, 2021
@Keymaster65
NPE due to concurrency bug #392: Make JsonSchemaRef more thread-safe;…
9a9032d 
… Removed unused members and constructor (#393)
@Keymaster65 Keymaster65 mentioned this issue Mar 31, 2021
Merged
@stevehu stevehu closed this as completed Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stevehu @Keymaster65