Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NAE-1970] Verification of Visual ID Generation to Prevent Duplicate IDs #260

Open
wants to merge 1 commit into
base: release/6.4.0
Choose a base branch
from

Conversation

machacjozef
Copy link
Member

@machacjozef machacjozef commented May 20, 2024

Description

Fixes NAE-1970

Dependencies

Third party dependencies

No new dependencies were introduced

Blocking Pull requests

There are no dependencies on other PR

How Has Been This Tested?

Test Configuration

Name Tested on
OS macOS Ventura 14.5
Runtime Java 11
Dependency Manager Maven 3.8.4
Framework version Spring Boot 2.7.8
Run parameters
Other configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes have been checked, personally or remotely, with @tuplle
  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved all conflicts with the target branch of the PR
  • I have updated and synced my code with the target branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes:
    • Lint test
    • Unit tests
    • Integration tests
  • I have checked my contribution with code analysis tools:
  • I have made corresponding changes to the documentation:
    • Developer documentation
    • User Guides
    • Migration Guides

@machacjozef machacjozef self-assigned this May 20, 2024
@machacjozef machacjozef added the bugfix A change that fixes a bug label May 20, 2024
Copy link
Contributor

@minop minop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believed the point of a visual ID is to be short and contain no meaningful information about the individual cases. The new visual IDs are long (22 characters with 3 character process initials) and contain the case creation time, as well as, the count of existing cases. With such long IDs is it not better to simply use the case IDs themselves everywhere? These IDs are no longer 'visual' in my opinion. Is the request for non-duplicate visual IDs even meaningful? Visual IDs are ~hashes and implicitly contain duplicates as a tradeoff for bravity.

@tuplle
Copy link
Member

tuplle commented May 29, 2024

I believed the point of a visual ID is to be short and contain no meaningful information about the individual cases. The new visual IDs are long (22 characters with 3 character process initials) and contain the case creation time, as well as, the count of existing cases. With such long IDs is it not better to simply use the case IDs themselves everywhere? These IDs are no longer 'visual' in my opinion. Is the request for non-duplicate visual IDs even meaningful? Visual IDs are ~hashes and implicitly contain duplicates as a tradeoff for bravity.

The purpose of a visual ID has changed based on a target project. We had several requests to format the visual ID as a unique numerical value. The process initial prefix is used for clarity. Visual ID is often used as a secondary ID as an ObjectID can be hard to understand to non-technical people. As for future releases visual ID is going to be deprecated in favour of generating own ID into a process data field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix A change that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants