Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NAE-1855] Configuration Properties cleanup #189

Open
wants to merge 2 commits into
base: release/8.0.0
Choose a base branch
from

Conversation

SamuelPalaj
Copy link
Contributor

@SamuelPalaj SamuelPalaj commented Apr 18, 2023

Description

  • removed instances of @value annotation
  • added multiple configuration properties classes

Implements NAE-1855

Dependencies

none

How Has Been This Tested?

Manually

Test Configuration

Name Tested on
OS windows 10
Runtime java 11
Dependency Manager Maven 3.8.4
Framework version Spring Boot 2.7.8
Run parameters
Other configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes have been checked, personally or remotely, with @...
  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved all conflicts with the target branch of the PR
  • I have updated and synced my code with the target branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes:
    • Lint test
    • Unit tests
    • Integration tests
  • I have checked my contribution with code analysis tools:
  • I have made corresponding changes to the documentation:
    • Developer documentation
    • User Guides
    • Migration Guides

- removed instances of @value annotation
- added multiple configuration properties classes
- CaseFieldsExpressionRunner constructor fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant