Closes: #15239 - Allow adding/removing tagged VLANs in bulk editing of Interfaces #17524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
requested changes
Sep 19, 2024
There was a problem hiding this comment.
Nice work with this @bctiemann, we just need to figure out a pattern for accommodating these non-model many-to-many fields generically.
Comment on lines
618
to
623
| # Add/remove tagged VLANs | ||
| if form.cleaned_data.get('add_tagged_vlans', None): | ||
| obj.tagged_vlans.add(*form.cleaned_data['add_tagged_vlans']) | ||
| if form.cleaned_data.get('remove_tagged_vlans', None): | ||
| obj.tagged_vlans.remove(*form.cleaned_data['remove_tagged_vlans']) | ||
|
|
There was a problem hiding this comment.
Model-specific fields can't go into a generic view. We'll need to come up with a pattern for handling these generically, probably in a manner similar to how we handle many-to-many assignments.
There was a problem hiding this comment.
Good point, how about this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #15239
Adds "Add Tagged VLANs" and "Remove tagged VLANs" widgets to the bulk edit form of Interfaces, both when editing them standalone and when accessing them as components of a device. These fields operate in the same way as the existing "Add tags"/"Remove tags" and allow the user to add or remove the selected items to all selected objects regardless of their existing VLANs, rather than having to set all objects to the same VLAN settings in the edit operation.
Note that this PR also cleans up the
__init__function ofInterfaceBulkEditForm, removing the after-the-fact modification of the widgets to add query parameters, as these params can be set in the field definitions directly using the$devicetoken.