feat: add GetMaxMatureBlockNumber func #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheWaWaR
reviewed
Apr 1, 2021
utils/util.go
Outdated
| numer uint64 | ||
| // Denominator. | ||
| denom uint64 | ||
| } |
TheWaWaR
reviewed
Apr 1, 2021
| tipEpochRN, cellbaseMaturityRN := epochRationalNum(tipEpoch, cellbaseMaturity) | ||
| if tipEpochRN.numer-cellbaseMaturityRN.numer < 0 { | ||
| return true | ||
| } |
TheWaWaR
reviewed
Apr 1, 2021
utils/util.go
Outdated
Comment on lines
171
to
176
| nodeVersion := strings.Split(nodeInfo.Version, " (") | ||
| versionArr := strings.Split(nodeVersion[0], ".") | ||
| major, err := strconv.Atoi(versionArr[0]) | ||
| minor, err := strconv.Atoi(versionArr[1]) | ||
| patch, err := strconv.Atoi(versionArr[2]) | ||
| return major, minor, patch, nil |
There was a problem hiding this comment.
Suggested change
| nodeVersion := strings.Split(nodeInfo.Version, " (") | |
| versionArr := strings.Split(nodeVersion[0], ".") | |
| major, err := strconv.Atoi(versionArr[0]) | |
| minor, err := strconv.Atoi(versionArr[1]) | |
| patch, err := strconv.Atoi(versionArr[2]) | |
| return major, minor, patch, nil | |
| nodeVersion := strings.Split(nodeInfo.Version, " (") | |
| versionArr := strings.Split(nodeVersion[0], ".") | |
| major, err := strconv.Atoi(versionArr[0]) | |
| minor, err := strconv.Atoi(versionArr[1]) | |
| patch, err := strconv.Atoi(versionArr[2]) | |
| return major, minor, patch, nil |
Put above line in a standalone function and test it.
TheWaWaR
reviewed
Apr 1, 2021
README.md
Outdated
| ScriptType: indexer.ScriptTypeLock, | ||
| Filter: &indexer.CellsFilter{ | ||
| BlockRange: &[2]uint64{0, maxMatureBlockNumber}, | ||
| }, |
There was a problem hiding this comment.
The filter is wrong, must only filter out cellbase, and cellbase not in genesis block.
TheWaWaR
reviewed
Apr 6, 2021
|
|
||
| // IsMature check if a cellbase live cell is mature | ||
| func IsMature(cell *indexer.LiveCell, maxMatureBlockNumber uint64) bool { | ||
| return cell.TxIndex > 0 || cell.BlockNumber == 0 || cell.BlockNumber <= maxMatureBlockNumber |
There was a problem hiding this comment.
same as here: https://github.com/nervosnetwork/ckb-indexer/blob/master/src/service.rs#L235
means transaction index in the block.
TheWaWaR
reviewed
Apr 7, 2021
README.md
Outdated
| } | ||
| if utils.IsMature(liveCell, maxMatureBlockNumber) { | ||
| cells = append(cells, liveCell) | ||
| } |
TheWaWaR
approved these changes
Apr 7, 2021
shaojunda
force-pushed
the
shaojunda-add-mature-block-range-sample
branch
from
e0b1f74
to
48474f1
Compare
shaojunda
force-pushed
the
shaojunda-add-mature-block-range-sample
branch
from
48474f1
to
b607158
Compare
duanyytop
approved these changes
Apr 7, 2021
shaojunda
force-pushed
the
shaojunda-add-mature-block-range-sample
branch
from
1a206cd
to
b607158
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.