New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved point cloud shader #158

Merged

brentyi merged 2 commits into main from brent/point_cloud_shaders

Jan 9, 2024

Collaborator

brentyi commented Jan 9, 2024

Point cloud rendering now:

Correctly takes the camera intrinsics into account. This puts point_size in the same units as everything else in viser. Points in the previous PointsMaterial implementation were always the same size regardless of FOV.
Supports rendering points of different shapes. A square for each point is still the default; we also added support for rounding the corners, circles, etc.

point_shape="rounded":

brentyi added 2 commits

January 8, 2024 15:52


          Improved point cloud shader

ed52f26


          Resolve eslint

036701a

brentyi merged commit 6e0000b into main

12 checks passed

brentyi deleted the brent/point_cloud_shaders branch

January 9, 2024 00:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet