Fix npm test when running test containers
#1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests were failing because Deno integration tests can't access a database. The problem happens because tests are using `TestContainers` by default and Deno doesn't have support for it yet. So, the problem is circuvented by skipping the Deno integration tests for the case we are using `testcontainers`. This is not a big issue since, 1. Pipelines and testkit doesn't make use of testcontainers, so the tests will not be skipped in important places. 2. The amount of testing scenarios are quite small and not likely to change in behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests were failing because Deno integration tests can't access a database.
The problem happens because tests are using
testcontainersby default and Deno doesn't have support for it yet.So, the problem is circumvented by skipping the Deno integration tests for the case we are using
testcontainers.This is not a big issue since,