This repository has been archived by the owner on Sep 3, 2021. It is now read-only.
Merge operation support #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream merge
This was implemented by unifying the merge logic with the update logic, with some minor branching used to capture translation differences.
Adds predicate functions for merge operations.
Fixes improper use of neo4j.int on whole number values provided to Float type fields on the Point type, in buildCypherParameters. For example, while a { height: 3.5 } param would be kept as { height: 3.5 }, if one were to provide { height: 3 }, then it would be inappropriately serialized to { height: {
low: 3, high: 0 } }.
Also changes the use of the pointKey Point type primary key on SpatialNode to use the non-pk 'point' field, since SpatialNode now has an 'id: ID' primary key.
Also updates the SpatialNode type to have an 'id: ID' primary key, given that the Point type should not be used
Codecov Report
@@ Coverage Diff @@
## master #355 +/- ##
==========================================
- Coverage 96.34% 96.33% -0.01%
==========================================
Files 24 24
Lines 2705 2812 +107
==========================================
+ Hits 2606 2709 +103
- Misses 99 103 +4
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains initial support for Merge operations for both nodes and relationships.