Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEP: Contract Basic Method Guideline #136

Closed
wants to merge 9 commits into from
Closed

NEP: Contract Basic Method Guideline #136

wants to merge 9 commits into from

Conversation

superboyiii
Copy link
Member

@superboyiii superboyiii commented Apr 19, 2021 •
edited
Loading

Close #135

@erikzhang
Copy link
Member

According to NEP-1, maybe this can be an Informational NEP.

An Informational NEP describes a NEO design issue, or provides general guidelines or information to the NEO community, but does not propose a new feature. Informational NEPs do not necessarily represent a NEO community consensus or recommendation, so users and implementors are free to ignore Informational NEPs or follow their advice.

shargon
shargon reviewed Apr 19, 2021
View reviewed changes
Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention _deploy method and the raised notification by the syscall?

@superboyiii
Copy link
Member Author

Mention _deploy method and the raised notification by the syscall?

Done.

@superboyiii superboyiii changed the title NEP: Contract Upgrade standard NEP: Contract basic method standard Apr 20, 2021
@superboyiii superboyiii changed the title NEP: Contract basic method standard NEP: Contract Basic Method Standard Apr 20, 2021
erikzhang
erikzhang reviewed Apr 20, 2021
View reviewed changes
nep-19.mediawiki Outdated Show resolved Hide resolved
@superboyiii
Copy link
Member Author

@erikzhang @shargon Any other advice?

@superboyiii superboyiii changed the title NEP: Contract Basic Method Standard NEP: Contract Basic Method Guideline Apr 21, 2021
shargon
shargon previously approved these changes Apr 21, 2021
View reviewed changes
@superboyiii superboyiii mentioned this pull request Apr 23, 2021
Merged
@superboyiii
Copy link
Member Author

Since NEP-19 has been created, to avoid conflict, I reopened another: #154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikzhang erikzhang erikzhang left review comments

@shargon shargon shargon approved these changes

Assignees
No one assigned
Labels
accepted NEP-Informational
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need a proposal for upgrade method in contract to unify the style
3 participants
@superboyiii @erikzhang @shargon