Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local runner doc #1911

Merged
merged 3 commits into from
Jul 21, 2023
Merged

local runner doc #1911

merged 3 commits into from
Jul 21, 2023

Conversation

taytzehao
Copy link
Contributor

Added documentation to demonstrate to users that --pull=false is an alternative for using local images.

#1896

@taytzehao taytzehao requested a review from a team as a code owner July 14, 2023 16:09
README.md Outdated Show resolved Hide resolved
@mergify
Copy link
Contributor

mergify bot commented Jul 14, 2023

@taytzehao this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Jul 14, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 17, 2023

@taytzehao this pull request has failed checks 🛠

@taytzehao
Copy link
Contributor Author

@cplee , the check seems to be failing in the recent PRs too. Dun't think that it is due to this documentation change

Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please press "Update Branch", to get CI passing.

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #1911 (c817d47) into master (4989f44) will increase coverage by 1.34%.
The diff coverage is 64.31%.

@@            Coverage Diff             @@
##           master    #1911      +/-   ##
==========================================
+ Coverage   61.22%   62.56%   +1.34%     
==========================================
  Files          46       51       +5     
  Lines        7141     8295    +1154     
==========================================
+ Hits         4372     5190     +818     
- Misses       2462     2706     +244     
- Partials      307      399      +92     
Impacted Files Coverage Δ
pkg/common/outbound_ip.go 0.00% <0.00%> (ø)
pkg/container/docker_cli.go 82.23% <ø> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/docker_volume.go 0.00% <0.00%> (ø)
pkg/container/file_collector.go 39.68% <0.00%> (+2.38%) ⬆️
pkg/container/host_environment.go 0.00% <0.00%> (ø)
...ontainer/linux_container_environment_extensions.go 23.07% <0.00%> (-1.25%) ⬇️
pkg/container/util.go 0.00% <0.00%> (ø)
pkg/exprparser/functions.go 66.32% <0.00%> (-1.04%) ⬇️
pkg/container/docker_run.go 13.58% <12.50%> (-0.01%) ⬇️
... and 30 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot removed the needs-work Extra attention is needed label Jul 20, 2023
@mergify mergify bot merged commit 67f4baa into nektos:master Jul 21, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants