Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove archives.replacements in goreleaser.yaml #1895

Merged
merged 5 commits into from
Jul 10, 2023

Conversation

wolfogre
Copy link
Member

@wolfogre wolfogre commented Jul 5, 2023

Fix #1894 and other CI failures.

archives.replacements has been removed since goreleaser v1.19.0. See https://goreleaser.com/deprecations/#archivesreplacements

Use an equivalent replacement to handle it.

To ensure that it is indeed equivalent, there's the archives of v0.2.46:

image

And the CI outputs of this PR:

image

@wolfogre wolfogre requested a review from a team as a code owner July 5, 2023 06:42
@mergify
Copy link
Contributor

mergify bot commented Jul 5, 2023

@wolfogre this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Jul 5, 2023
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #1895 (6e6dcbd) into master (4989f44) will increase coverage by 1.39%.
The diff coverage is 64.90%.

@@            Coverage Diff             @@
##           master    #1895      +/-   ##
==========================================
+ Coverage   61.22%   62.61%   +1.39%     
==========================================
  Files          46       51       +5     
  Lines        7141     8247    +1106     
==========================================
+ Hits         4372     5164     +792     
- Misses       2462     2690     +228     
- Partials      307      393      +86     
Impacted Files Coverage Δ
pkg/common/outbound_ip.go 0.00% <0.00%> (ø)
pkg/container/docker_cli.go 82.23% <ø> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/docker_run.go 13.58% <0.00%> (-0.01%) ⬇️
pkg/container/docker_volume.go 0.00% <ø> (ø)
pkg/container/file_collector.go 39.68% <0.00%> (+2.38%) ⬆️
pkg/container/host_environment.go 0.00% <0.00%> (ø)
...ontainer/linux_container_environment_extensions.go 23.07% <0.00%> (-1.25%) ⬇️
pkg/exprparser/functions.go 66.32% <0.00%> (-1.04%) ⬇️
pkg/model/workflow.go 42.33% <8.88%> (+0.21%) ⬆️
... and 26 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot removed the needs-work Extra attention is needed label Jul 5, 2023
ChristopherHX
ChristopherHX previously approved these changes Jul 5, 2023
Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should hardcode the goreleaser version and bump via a PR, it is an unwanted side effect that a new release of an external tool breaks between the last merged pr and the automatic release.

We should replace --rm-dist with --clean, we may end up again in this error due to removed cli flag.

Mips is unused in nektos/act, so removal of the suffix doesn't matter.

I wonder why {{ .Os }} is not in lowercase and don't need a replacement.

@mergify mergify bot merged commit 15618d1 into nektos:master Jul 10, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.2.47 release was not completed
3 participants