-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove archives.replacements
in goreleaser.yaml
#1895
Conversation
@wolfogre this pull request has failed checks 🛠 |
Codecov Report
@@ Coverage Diff @@
## master #1895 +/- ##
==========================================
+ Coverage 61.22% 62.61% +1.39%
==========================================
Files 46 51 +5
Lines 7141 8247 +1106
==========================================
+ Hits 4372 5164 +792
- Misses 2462 2690 +228
- Partials 307 393 +86
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should hardcode the goreleaser version and bump via a PR, it is an unwanted side effect that a new release of an external tool breaks between the last merged pr and the automatic release.
We should replace --rm-dist
with --clean
, we may end up again in this error due to removed cli flag.
Mips is unused in nektos/act, so removal of the suffix doesn't matter.
I wonder why {{ .Os }}
is not in lowercase and don't need a replacement.
Fix #1894 and other CI failures.
archives.replacements
has been removed since goreleaser v1.19.0. See https://goreleaser.com/deprecations/#archivesreplacementsUse an equivalent replacement to handle it.
To ensure that it is indeed equivalent, there's the archives of
v0.2.46
:And the CI outputs of this PR: