Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/stochastic resolve #231

Merged
merged 2 commits into from
Apr 16, 2023
Merged

Feat/stochastic resolve #231

merged 2 commits into from
Apr 16, 2023

Conversation

rneher
Copy link
Member

@rneher rneher commented Apr 16, 2023

This adds a new way to resolve polytomies. The previous polytomy resolution greedily pulled out pairs of child-clades at a time and merged then into a single clade. This often results in atypical caterpillar like subtrees.

image

This is undesirable since it (i) is very atypical, (ii) causes numerical issues due to repeated convolutions, and (iii) triggers recursion errors during newick export.

The new optional way of resolving replaces a multi-furcation by a randomly generated coalescent tree that backwards in time mutates (all mutations are singletons and need to 'go' before coalescence), and merges lineages. Lineages that remain when time reaches the time of the parent remain as children of the parent.

This new way of resolving is much faster for large polytomies. It is currently implemented as an optional experimental feature that can be used via the flag --stochastic-resolve. Note that the outcome of this stochastic resolution is stochastic!

@rneher rneher merged commit 9d0c6ba into master Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant