Fix/update version tags without deleting #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simoneb
reviewed
Sep 26, 2023
simoneb
reviewed
Sep 26, 2023
src/utils/tagVersion.js
Outdated
| await execWithOutput('git', ['tag', '-f', `${version}`]) | ||
| await execWithOutput('git', ['push', 'origin', `--tags`]) | ||
| await execWithOutput('git', ['push', 'origin', `-f`, `${version}`]) |
There was a problem hiding this comment.
Suggested change
| await execWithOutput('git', ['push', 'origin', `-f`, `${version}`]) | |
| await execWithOutput('git', ['push', 'origin', `-f`, version]) |
simoneb
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of deleting the old version tags and replacing them with a new tag of the same name, we can force push the new tags which replaces the old tags of the same name with the new ones. This way it is not possible for the action to fail in between the steps of deleting the old tags and creating the new tag, leaving us with no tag at all.
closes: nearform-actions/github-action-notify-release#657