fix(issue 295): ensure inputs don't leak to child processes #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simoneb
reviewed
May 3, 2023
|
Not sure. Ultimately it depends on an internal behaviour of GitHub Actions that ends in a child process. so I don't think we can test that? At least I don't think we can do any kind of full integration test here. Maybe we can and should have a basic unit test that stubs |
|
yes please, let's have a unit test for this behavior |
|
I'm sure you noticed but CI is red @AlanSl |
simoneb
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #295
I split this out from the provenance work because it's a separate issue, posting this as an example implementation if we do think it's something worth doing. Not sure if it should have tests or not or if it's really possible to test?