Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation for playground repo and add automatic TOC update #255

Merged
merged 5 commits into from
Jan 20, 2023
Merged

Update documentation for playground repo and add automatic TOC update #255

merged 5 commits into from
Jan 20, 2023

Conversation

p16
Copy link
Contributor

@p16 p16 commented Jan 20, 2023

Fixes #253

simoneb
simoneb reviewed Jan 20, 2023
View reviewed changes
Copy link
Contributor

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that the bulk of this should be in the playground repo, not in this one. this one should contain a link to the playground repo saying: "hey for development use the playground repo to test your changes"

@p16
Copy link
Contributor Author

p16 commented Jan 20, 2023

ah ok, will move it there then 👍

@p16
Copy link
Contributor Author

p16 commented Jan 20, 2023

PR on playground repo https://github.com/nearform/optic-release-automation-playground/pull/15

simoneb
simoneb reviewed Jan 20, 2023
View reviewed changes
README.md

## Playground / Testing

Please look at the [playground reposity](https://github.com/nearform/optic-release-automation-playground) for more informations (only accessible by users in the NearForm org).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gregoryduckworth as part of the migration of the repos to the new org, we need to add to the todo list checking links in docs to make sure they point to the new repos. now, github may be handling the redirects already, but since we're there let's fix them

@p16 p16 merged commit 0452cf5 into main Jan 20, 2023
@p16 p16 deleted the add-documentation branch January 20, 2023 12:27
@github-actions github-actions bot mentioned this pull request Jan 28, 2023
Closed
@github-actions github-actions bot mentioned this pull request Feb 6, 2023
Closed
@github-actions github-actions bot mentioned this pull request Feb 14, 2023
Closed
@optic-release-automation optic-release-automation bot mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simoneb simoneb simoneb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document how to use the playground repository for testing
2 participants
@p16 @simoneb