Auto version bump #202
Auto version bump #202
Conversation
|
Even if this receives reviews, please wait for my review before merging due to the potentially disruptive impact of this change |
|
@davideroffo can you please review this? |
|
@sameer-coder I noticed that the |
README.md
Outdated
| @@ -195,7 +200,7 @@ Please note that in case of a prerelease the `sync-semver-tags` input will be tr | |||
| | Input | Required | Description | | |||
| | --- | --- | --- | | |||
| | `github-token` | No | This is your GitHub token, it's [already available](https://docs.github.com/en/actions/security-guides/automatic-token-authentication#about-the-github_token-secret) to your GitHub action | | |||
| | `semver` | Yes | The version you want to bump (`patch|minor|major`). | | |||
| | `semver` | Yes | The version you want to bump (`auto|patch|minor|major`). | | |||
There was a problem hiding this comment.
this isn't actually up to date. when we introduced support for prereleases we included more options. maybe, instead of listing them, we should just link the npm docs page
src/index.js
Outdated
| let latestTag = null | ||
| if (!baseTag) { | ||
| const allTags = await run('git', ['tag', '--sort=-creatordate']) | ||
| const tags = allTags.split('\n') | ||
| latestTag = tags[0] || null | ||
| } |
There was a problem hiding this comment.
all this explicit null handling isn't very intuitive, and probably unnecessary (including the default value of this function's arg)
There was a problem hiding this comment.
also prefer avoiding mutable state please, there's most certainly a more elegant way to write this that doesn't require let variables
This PR introduces the auto version bump feature.
The user can now choose the "auto" option for semver version updates. The action will attempt to determine the new version number based on the commit messages. For this option to work, the repository must use the conventional commits standard.
Closes #193