-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace fungible token example sim tests with workspaces #699
Merged
Merged
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
4d62cdb
refactor: replace fungible token example sim tests with workspaces
itegulov 7183ff2
refactor initialization
itegulov eb26d03
refactor some workspaces usage to be more canonical
itegulov 03fc85d
Merge branch 'master' into daniyar/fungible-token-example-workspaces
itegulov 7c2d4c1
replace near constants with `parse_near!` macro
itegulov eee6eb2
use `Option::<T>::None` for creating `None`s
itegulov 37aafef
address comments
itegulov f6f9e54
use a snapshot version of workspaces
itegulov 1688ecb
use workspaces 0.1.1
itegulov 3d3a5b8
Merge branch 'master' into daniyar/fungible-token-example-workspaces
itegulov b312fb1
address comments
itegulov 1af263a
re-generate wasm files
itegulov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Binary file not shown.
Binary file not shown.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah an extension of what Phuong mentioned, this shouldn't be included
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @ChaoticTempest mentioned in the other thread I actually need this to pull
FinalExecutionStatus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like something that shouldn't be exposed through workspaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, do you mean that workspaces should have its own type for expressing the call execution status?
CC @ChaoticTempest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, this is not an ideal pattern for workspace users to have to import a nearcore internal crate. Not a big deal, but something that should be changed at some point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooof, this was a pattern I wasn't expecting to cover with
asserts!
withFinalExecutionStatus
. Think we can defer this later until a new minor version of workspaces is released and we can convert theseasserts!
over to usingis_success
callsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we can defer for sure and
is_success
will help in this case, butCallExecutionDetails::status
(which is a part of the public API) will still be a type fromnear-primitives
so I think eventually we would want to replace it with something else.