refactor: use attr sig info in abi generator #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Buildkite failed with an "Address already in use" error for an integration test. Should be fine if reran. |
frol
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues where #1033 left off.
The PR first adds test coverage for the abi generator in 338c0b1 (fixes #1031). The tests don't cover all combinations, but they should cover all features.
In the second step, the PR refactors the abi generator to use the new
AttrSigInfostruct introduced in #1025 (fixes #1032).Finally, the PR cleans up the code that was necessary to support two versions of the
AttrSigInfostruct while the refactoring was in progress.