Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added handleCloseSearchMenu to close search UI #521

Conversation

erditkurteshiSQA
Copy link
Contributor

Fixes near/near-discovery#807 .

This PR is related with: near/near-discovery#821

@erditkurteshiSQA erditkurteshiSQA added the bug Something isn't working. Highlights a PR's description in the 'Fixes' changelog section label Nov 13, 2023
Copy link
Collaborator

@calebjacob calebjacob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment here on the gateway: near/near-discovery#821 (comment)

This just means our code would change to this:

const handleCloseSearchMenu = () => {
  props.focusChange(false);
}

Copy link
Collaborator

@calebjacob calebjacob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes! :) Looks good.

@erditkurteshiSQA erditkurteshiSQA merged commit 272baf9 into develop Nov 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. Highlights a PR's description in the 'Fixes' changelog section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Global Search overlay consistently blocks the UI
2 participants