Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: move zoom_get_user_display_name function from view.php to locallib #584

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

karenliulll
Copy link
Contributor

Fixes #580

@karenliulll karenliulll self-assigned this Apr 3, 2024
locallib.php Outdated Show resolved Hide resolved
@jrchamp jrchamp force-pushed the fix/move-function-to-locallib branch from cb97f58 to fd39504 Compare April 8, 2024 22:41
Copy link
Collaborator

@jrchamp jrchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Sorry to pollute the commit history with fixes so the tests pass.

@jrchamp jrchamp merged commit 6b23f5c into main Apr 8, 2024
14 checks passed
@jrchamp jrchamp deleted the fix/move-function-to-locallib branch April 8, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Cleanup: move zoom_get_user_display_name function out of view.php
2 participants