upgrade: set null registration values to new default before alter #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @smbader for agreeing to review |
|
I performed an upgrade to 2024012500 on several Zoom instances with varying registration values including null. The column was converted to not null and all null values were changed to 2. Success. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the XMLDB Editor provides helpful PHP code to update fields, the underlying functions do not automatically make sure to set the NULL values to the new default value when switching the nullability of the field.
Here's a similar example from Moodle core: https://github.com/moodle/moodle/blame/3fc907e3d8646d53b744cbeb2820f5a060cc86ee/lib/db/upgrade.php#L816-L821
Fixes #573