Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db: revert registration upgrade; fix tables that upgraded #565

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

jrchamp
Copy link
Collaborator

@jrchamp jrchamp commented Jan 18, 2024

The registration field definition was unintentionally changed. Some users upgraded after that change and have the wrong database column settings. After upgrading again, those users will have the correct column settings.

Fixes #563
Regression from #505

@jrchamp jrchamp added the bug Fixes problems or reduces technical debt label Jan 18, 2024
@jrchamp jrchamp requested a review from a team January 18, 2024 16:58
@jrchamp jrchamp self-assigned this Jan 18, 2024
The registration field definition was unintentionally changed. Some users upgraded after that change and have the wrong database column settings. After upgrading again, those users will have the correct column settings.
@jrchamp jrchamp force-pushed the fix/registration-column-db-settings branch from 28dd73e to d48bdc5 Compare January 19, 2024 17:50
db/upgrade.php Outdated Show resolved Hide resolved
armccoy
armccoy previously approved these changes Jan 25, 2024
Copy link
Contributor

@armccoy armccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@armccoy armccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I SAID IT LOOKS GOOD!!

@jrchamp jrchamp merged commit 0b678e2 into main Jan 25, 2024
14 checks passed
@jrchamp jrchamp deleted the fix/registration-column-db-settings branch January 25, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes problems or reduces technical debt
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Database schema is not aligned - column 'registration'
2 participants