Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

db: remove start_url from zoom table #546

Merged
merged 3 commits into from
Nov 30, 2023
Merged

db: remove start_url from zoom table #546

merged 3 commits into from
Nov 30, 2023

Conversation

smbader
Copy link
Contributor

@smbader smbader commented Nov 16, 2023 •
edited
Loading

Cleanup work to remove start_url from the database.

Testing:

  • Should install with no issues as a new plugin.
  • Should upgrade with no issues as an existing plugin.
  • The functionality of the plugin should not be affected.

Fixes #326

@smbader smbader added the enhancement Adds new functionality label Nov 16, 2023
@smbader smbader requested a review from a team November 16, 2023 15:59
@smbader smbader self-assigned this Nov 16, 2023
@smbader smbader linked an issue Nov 16, 2023 that may be closed by this pull request
Remove unused start_url from the database #326
Closed
@smbader smbader marked this pull request as ready for review November 16, 2023 19:26
jrchamp
jrchamp approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@jrchamp jrchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@jrchamp jrchamp merged commit 3cd1bfe into ncstate-delta:main Nov 30, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrchamp jrchamp jrchamp approved these changes

Assignees

@smbader smbader

Labels
enhancement Adds new functionality
Projects
Pull Requests
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unused start_url from the database
2 participants
@smbader @jrchamp