Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow editing description for existing meetings #545

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

armccoy
Copy link
Contributor

@armccoy armccoy commented Nov 16, 2023

Skips "new activity" check to allow updating meeting descriptions for existing and past meetings.
If necessary, a further edit could skip the "new activity" check if the meeting already exists AND if the meeting date/time hasn't changed.

@armccoy armccoy linked an issue Nov 16, 2023 that may be closed by this pull request
@jrchamp
Copy link
Collaborator

jrchamp commented Nov 16, 2023

Things to test:

  • Edit only the description and make sure it successfully displays in Moodle
    • This must be successful for this PR to have benefit.
  • Edit the description and the start time, setting the start time to a different time that is in the past
    • What is the error that occurs?
    • Does the description save in Moodle?
    • Does the description save in Zoom? If not, do we care?

@sgrandh3
Copy link
Collaborator

Tested the changes for also recurring meetings along with past meetings. The instructor can change the description for existing meetings

Copy link
Collaborator

@jrchamp jrchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sgrandh3 for testing!

@jrchamp jrchamp merged commit 7baf3c2 into main Nov 30, 2023
14 checks passed
@jrchamp jrchamp deleted the 297-ability-to-edit-a-zoom-event-that-is-in-the-past branch November 30, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Ability to edit a zoom event that is in the past
3 participants