Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: restore try catch namespace #537

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Fix: restore try catch namespace #537

merged 3 commits into from
Nov 2, 2023

Conversation

jrchamp
Copy link
Collaborator

@jrchamp jrchamp commented Oct 26, 2023

Fixes a regression in v5.1.1 where an exception during restore was not caught as a result of namespace issues. While we're here, make the namespaced files leverage use statements to simplify lengthy class references.

@jrchamp jrchamp added the bug Fixes problems or reduces technical debt label Oct 26, 2023
@jrchamp jrchamp requested a review from a team October 26, 2023 20:52
@jrchamp jrchamp self-assigned this Oct 26, 2023
smbader
smbader approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@smbader smbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use use!

@jrchamp jrchamp merged commit 9dc0f49 into ncstate-delta:main Nov 2, 2023
7 checks passed
@jrchamp jrchamp deleted the fix/restore-try-catch-namespace branch November 2, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smbader smbader smbader approved these changes

Assignees

@jrchamp jrchamp

Labels
bug Fixes problems or reduces technical debt
Projects
Pull Requests
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrchamp @smbader