Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: define class properties (PHP 8.2) #522

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

jrchamp
Copy link
Collaborator

@jrchamp jrchamp commented Sep 22, 2023

When running the tests on a PHP 8.2 system with display_errors on, deprecated messages showed up.

@jrchamp jrchamp added the bug Fixes problems or reduces technical debt label Sep 22, 2023
@jrchamp jrchamp requested a review from a team September 22, 2023 21:09
@jrchamp jrchamp self-assigned this Sep 22, 2023
@jrchamp jrchamp marked this pull request as ready for review September 22, 2023 21:10
@jrchamp jrchamp force-pushed the fix/php-82-dynamic-properties branch from dc652a2 to a4276a2 Compare September 28, 2023 05:52
Copy link
Contributor

@smbader smbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember kids, define your class properties.

@jrchamp jrchamp merged commit 67a04c4 into ncstate-delta:main Sep 28, 2023
6 checks passed
@jrchamp jrchamp deleted the fix/php-82-dynamic-properties branch September 28, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes problems or reduces technical debt
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants