Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPCS - use moodle-extra standard #521

Merged
merged 5 commits into from
Sep 28, 2023

Conversation

jrchamp
Copy link
Collaborator

@jrchamp jrchamp commented Sep 21, 2023

More strict standard should allow us to more easily review pull requests.

In draft until #517 is merged. I'll rebase at that point.

@jrchamp jrchamp added the bug Fixes problems or reduces technical debt label Sep 21, 2023
@jrchamp jrchamp self-assigned this Sep 21, 2023
@jrchamp jrchamp marked this pull request as ready for review September 28, 2023 06:08
Copy link
Contributor

@smbader smbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistency is key.

@jrchamp jrchamp merged commit 6c7eb69 into ncstate-delta:main Sep 28, 2023
6 checks passed
@jrchamp jrchamp deleted the fix/use-moodle-extra branch September 28, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes problems or reduces technical debt
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants