Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft: Juliano/cleanup #14

Merged
merged 7 commits into from
Jul 5, 2024
Merged

draft: Juliano/cleanup #14

merged 7 commits into from
Jul 5, 2024

Conversation

ncode
Copy link
Owner

@ncode ncode commented Jul 5, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 94.11765% with 7 lines in your changes missing coverage. Please review.

Project coverage is 94.58%. Comparing base (bce6e2d) to head (ea74091).

Files Patch % Lines
pkg/aclmanager/aclmanager.go 94.11% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   87.43%   94.58%   +7.14%     
==========================================
  Files           1        1              
  Lines         191      240      +49     
==========================================
+ Hits          167      227      +60     
+ Misses         19       10       -9     
+ Partials        5        3       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ncode ncode merged commit b9dd2b1 into main Jul 5, 2024
2 of 3 checks passed
@ncode ncode deleted the juliano/cleanup branch July 5, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants