Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AFP offentlig fields to PensjonData #3623

Merged
merged 16 commits into from
Sep 20, 2024
Merged

Add AFP offentlig fields to PensjonData #3623

merged 16 commits into from
Sep 20, 2024

Conversation

krharum
Copy link
Contributor

@krharum krharum commented Sep 16, 2024

Introduced a new inner class AfpOffentlig with relevant fields and methods to handle AFP offentlig data. This includes new constraints using @Min and @Max annotations, and additional enumerations for StatusAfp. These changes enhance the model to support detailed information about AFP offentlig.

Introduced a new inner class `AfpOffentlig` with relevant fields and methods to handle AFP offentlig data. This includes new constraints using `@Min` and `@Max` annotations, and additional enumerations for `StatusAfp`. These changes enhance the model to support detailed information about AFP offentlig.
…proxy

Enhanced the proxy application to support routing for AFP Offentlig mock endpoints. Refactored configuration to accommodate dynamic environment-specific URLs and namespaces. Added new server properties classes for better code organization and maintainability.
Introduced new commands and mappings to handle "AfpOffentlig" requests in PensjonforvalterConsumer. Extended status mapping and data domain to include AfpOffentlig.
#deploy-pensjon-testdata-proxy
@deploy-pensjon-testdata-proxy

Introduce a new `application-prod.yml` for production OAuth2 setup. Simplify LocalVaultConfig by removing redundant token checks and adding `@NonNull` annotations.
#deploy-pensjon-testdata-proxy

Updated the Pensjon Testdata Facade and AFP Offentlig URLs to new environments. Modified corresponding YAML configuration files to align with the new URL settings and namespaces. Added missing ServerProperties for Pensjon Testdata Facade in the Consumers configuration.
Changed the URL parameter from 'fnr' to 'ident' in `SletteAfpOffentligCommand` and updated the response handling in `LagreAfpOffentligCommand`. This ensures consistent usage of the identifier field across requests and responses.
#deploy-pensjon-testdata-proxy

Adjusted the HTTP client response-timeout from 1200s to 10s and enabled wiretap for both the client and server to assist in debugging. Additionally, configured logging levels for better traceability within Spring Cloud Gateway components.
#deploy-pensjon-testdata-proxy

The afp-offentlig mock service has been removed from the application-dev.yml configuration. The service URL and cluster information have been updated in the application.yml file to reflect the new environment settings.
#deploy-test-dolly-backend
#deploy-pensjon-testdata-proxy

Changed cluster configuration from dev-fss to dev-gcp for specific applications in the config file. Modified logging messages and switched the HTTP method from POST to PUT for storing AFP-Offentlig data in the relevant Java command class.
@krharum krharum marked this pull request as ready for review September 18, 2024 10:53
@krharum krharum requested a review from a team as a code owner September 18, 2024 10:53
#deploy-test-dolly-backend

Corrected the PEN_AFP_OFFENTLIG constant to include a trailing '#'. This ensures consistent formatting with other similar constants and may prevent potential issues during data processing.
Copy link
Contributor

@stigus stigus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😄

@krharum krharum merged commit b14dd0c into master Sep 20, 2024
55 checks passed
@krharum krharum deleted the feature/afp-offentlig branch September 20, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants