Fjern mangler tilgang page #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fjerner egen side for /mangler-tilgang. Hvis bruker ikke har noen som helst tilganger, så rendres mangler-tilgangsiden med en gang det oppdages. Dette var ikke mulig før, siden vi da hadde uinnloggede sider.
|
Blir kanskje ikke clean merge med #1724. Kan fikse det jeg, altså. |
kenglxn
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Når jeg har forsøkt å forbedre koden tidligere, spesielt i top-level contextene, så har feilhåndtering vært utfordrende. Jeg tror det har med at når feil oppstår, så puttes det inn i state/context, men vi clearer ikke alltid feilmeldingene. Og hvis man i et brøkdel av et sekund havner i en tilstand hvor man tilsynelatende ikke har tilganger, så redirectes brukeren til
/mangler-tilgangog blir stuck der.Endrer derfor
OrganisasjonerOgTilgangerProvider.tsxtil å dynamisk vise siden for ingen tilganger.