fix: Correct typo in BarOptions #3749
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @wnolden thanks for the contribution! |
github-actions bot
pushed a commit
that referenced
this pull request
May 21, 2024
# [3.12.0-next.2](3.12.0-next.1...3.12.0-next.2) (2024-05-21) ### Bug Fixes * **api:** Fix scatter type loading ([413812d](413812d)), closes [#3740](#3740) * **treemap:** Fix missing element arg on data.onover/out ([22428dc](22428dc)), closes [#3766](#3766) * **types:** Correct typo in BarOptions ([a0ad93a](a0ad93a)), closes [#3749](#3749) ### Features * **axis:** Intent to ship axis.x.forceAsSingle ([6ad0554](6ad0554)), closes [#3764](#3764) * **funnel:** Intent to ship funnel type ([e4cdda1](e4cdda1)), closes [#3449](#3449)
github-actions bot
pushed a commit
that referenced
this pull request
May 27, 2024
# [3.12.0](3.11.3...3.12.0) (2024-05-27) ### Bug Fixes * **api:** Fix scatter type loading ([413812d](413812d)), closes [#3740](#3740) * **treemap:** Fix missing element arg on data.onover/out ([22428dc](22428dc)), closes [#3766](#3766) * **types:** Add missing arc.needle.value ([e0a30fe](e0a30fe)), closes [#3697](#3697) * **types:** Add missing region.label option ([e03057c](e03057c)), closes [#3732](#3732) * **types:** Correct typo in BarOptions ([a0ad93a](a0ad93a)), closes [#3749](#3749) ### Features * **axis:** Intent to ship axis.tooltip ([54e77cb](54e77cb)), closes [#3603](#3603) * **axis:** Intent to ship axis.x.forceAsSingle ([6ad0554](6ad0554)), closes [#3764](#3764) * **bundler:** Migrate babel -> esbuild ([ff0a98c](ff0a98c)), closes [#3601](#3601) * **funnel:** Intent to ship funnel type ([e4cdda1](e4cdda1)), closes [#3449](#3449)
github-actions bot
pushed a commit
that referenced
this pull request
May 27, 2024
# [3.12.0](3.11.3...3.12.0) (2024-05-27) ### Bug Fixes * **api:** Fix scatter type loading ([413812d](413812d)), closes [#3740](#3740) * **treemap:** Fix generation w/non-exist node ([02987ab](02987ab)), closes [#3777](#3777) * **treemap:** Fix missing element arg on data.onover/out ([22428dc](22428dc)), closes [#3766](#3766) * **types:** Add missing arc.needle.value ([e0a30fe](e0a30fe)), closes [#3697](#3697) * **types:** Add missing region.label option ([e03057c](e03057c)), closes [#3732](#3732) * **types:** Correct typo in BarOptions ([a0ad93a](a0ad93a)), closes [#3749](#3749) * **types:** Fix missing polar type ([7f5d5b0](7f5d5b0)), closes [#3778](#3778) ### Features * **axis:** Intent to ship axis.tooltip ([54e77cb](54e77cb)), closes [#3603](#3603) * **axis:** Intent to ship axis.x.forceAsSingle ([6ad0554](6ad0554)), closes [#3764](#3764) * **bundler:** Migrate babel -> esbuild ([ff0a98c](ff0a98c)), closes [#3601](#3601) * **funnel:** Intent to ship funnel type ([e4cdda1](e4cdda1)), closes [#3449](#3449)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
None
Details
Hi, this fixes a small typo in the BarOptions type definition.
Right now, TypeScript throws an error if you use the correct
overlap.