Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error throw when tooltip.show=false is set #3396

Closed
netil opened this issue Sep 4, 2023 · 0 comments
Closed

error throw when tooltip.show=false is set #3396

netil opened this issue Sep 4, 2023 · 0 comments
Assignees
Labels

Comments

@netil
Copy link
Member

netil commented Sep 4, 2023

Description

When tooltip.show=false is set, hovering chart area will throw error.
Seems side effect caused from #3292

Steps to check or reproduce

bb.generate({
  data: {
    columns: [
      ["data1", 30, 200, 100, 400, 150, 250],
      ["data2", 130, 100, 140, 200, 150, 50]
    ],
    type: "bar", // for ESM specify as: bar()
  },
  bar: {
    width: {
      ratio: 0.5
    }
  },
  tooltip: {
    show: false,
  },
});
@netil netil added the bug label Sep 4, 2023
@netil netil self-assigned this Sep 4, 2023
netil pushed a commit that referenced this issue Sep 4, 2023
- Fix side effect casued from 49a7a63
- Add prevention when calling tooltip.daum()

Ref #3396
github-actions bot pushed a commit that referenced this issue Sep 4, 2023
## [3.9.4](3.9.3...3.9.4) (2023-09-04)

### Bug Fixes

* **tooltip:** Fix error throw when tooltip.show=false is set ([4081a90](4081a90)), closes [#3396](#3396)
@netil netil closed this as completed Sep 5, 2023
netil pushed a commit to netil/billboard.js that referenced this issue Sep 5, 2023
- Reinforce test case
- Add conditional on calling .setTooltipPosition()

Ref naver#3396
netil added a commit that referenced this issue Sep 5, 2023
- Reinforce test case
- Add conditional on calling .setTooltipPosition()

Ref #3396
github-actions bot pushed a commit that referenced this issue Sep 8, 2023
# [3.10.0-next.2](3.10.0-next.1...3.10.0-next.2) (2023-09-08)

### Bug Fixes

* **api:** Fix to return indexed categories ([1209138](1209138)), closes [#3365](#3365)
* **bar:** Fix stacking bar position on multiple xs ([674bad1](674bad1)), closes [#3372](#3372)
* **candlestick:** Fix rendering on rotated axis ([fe4c04b](fe4c04b)), closes [#3387](#3387)
* **clip:** Fix x axis hide on title.bottom ([d00052c](d00052c)), closes [#3364](#3364)
* **point:** Fix rendering error when point.focus.only=true is set ([787fd15](787fd15)), closes [#3406](#3406)
* **shape:** Fix circleY() undefined error ([d245853](d245853)), closes [#3388](#3388)
* **subchart, zoom:** Fix returning domain value ([321510b](321510b)), closes [#3347](#3347)
* **subchart:** Fix handlebar position ([83ef6d0](83ef6d0)), closes [#3358](#3358)
* **title:** fix title text center align ([b0fc214](b0fc214)), closes [#3363](#3363)
* **tooltip:** Fix error throw when tooltip.show=false is set ([4081a90](4081a90)), closes [#3396](#3396)
* **tooltip:** Fix tooltip.format.value call ([2e88484](2e88484)), closes [#3371](#3371)
* **tooltip:** Fix tootip display on tooltip.init ([52083bf](52083bf)), closes [#3369](#3369)

### Features

* **api:** Intent to ship subchart method ([ac9e229](ac9e229)), closes [#3342](#3342)
* **point:** Intent to ship point.radialGradient ([7b51fd6](7b51fd6)), closes [#3405](#3405)
* **regions:** Intent to ship regions.label ([0496ec6](0496ec6)), closes [#3319](#3319)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant