Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(bug) line.connectNull: true breaks area-step when one data row has only null values #3124

Closed
michkami opened this issue Mar 8, 2023 · 0 comments
Closed

(bug) line.connectNull: true breaks area-step when one data row has only null values #3124

michkami opened this issue Mar 8, 2023 · 0 comments
Assignees
@netil
Labels
bug

Comments

@michkami
Copy link
Collaborator

michkami commented Mar 8, 2023

Description

It can happen that all values in one row can be null, especially when you load the chart values dynamically.
When using line.connectNull in combination with axis.x.type: "category" and area-step as data type it will result in an error and breaks the chart:
grafik

Expected:
grafik

Steps to check or reproduce

https://jsfiddle.net/michkami/sewghm35/
@netil netil self-assigned this Mar 14, 2023
@netil netil added the bug label Mar 14, 2023
netil pushed a commit to netil/billboard.js that referenced this issue Mar 14, 2023
fix(data): fix break when whole dataseries are null
e4f9c75 
Fix convert data for step when has no value

Ref naver#3124
@netil netil mentioned this issue Mar 14, 2023
Merged
netil added a commit that referenced this issue Mar 14, 2023
@netil
fix(data): fix break when whole dataseries are null (#3134)
5d12c45 
Fix convert data for step when has no value

Ref #3124

Co-authored-by: netil <netil@AL02015654.local>
@netil netil closed this as completed Mar 14, 2023
github-actions bot pushed a commit that referenced this issue Mar 31, 2023
@semantic-release-bot
chore(release): 3.8.0-next.1 [skip ci]
e5490c8 
# [3.8.0-next.1](3.7.5...3.8.0-next.1) (2023-03-31)

### Bug Fixes

* **data:** fix break when whole dataseries are null ([#3134](#3134)) ([5d12c45](5d12c45)), closes [#3124](#3124)
* **options:** Fix handling for falsy data.types ([5eb731a](5eb731a)), closes [#3125](#3125)

### Features

* **api:** Enhance resizeAfter for .load/unload APIs ([33bbca4](33bbca4)), closes [#3157](#3157)
* **axis:** Intent to ship axis.x.inverted ([e193c0f](e193c0f)), closes [#3137](#3137)
* **module:** Support dual CJS/ESM package ([437c007](437c007)), closes [#2202](#2202)
* **padding:** Intent to ship padding='fit' ([d760a63](d760a63)), closes [#3118](#3118)
* **plugin:** Intent to ship TableView plugin ([215b611](215b611)), closes [#1873](#1873)
github-actions bot pushed a commit that referenced this issue Apr 13, 2023
@semantic-release-bot
chore(release): 3.8.0 [skip ci]
d760c08 
# [3.8.0](3.7.5...3.8.0) (2023-04-13)

### Bug Fixes

* **data:** fix break when whole dataseries are null ([#3134](#3134)) ([5d12c45](5d12c45)), closes [#3124](#3124)
* **grid:** fix redundant <rect> appends ([1039363](1039363)), closes [#3147](#3147)
* **options:** Fix handling for falsy data.types ([5eb731a](5eb731a)), closes [#3125](#3125)
* **sparkline:** Fix to work point.focus.only option ([65b3c1c](65b3c1c)), closes [#3171](#3171)

### Features

* **api:** Enhance resizeAfter for .load/unload APIs ([33bbca4](33bbca4)), closes [#3157](#3157)
* **axis:** Intent to ship axis.x.inverted ([e193c0f](e193c0f)), closes [#3137](#3137)
* **package:** extends root div interface for styling ([0a1fe08](0a1fe08)), closes [#3162](#3162) [#3163](#3163)
* **padding:** Intent to ship padding='fit' ([d760a63](d760a63)), closes [#3118](#3118)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@netil netil

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@netil @michkami