Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wget to release image #30

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Add wget to release image #30

merged 1 commit into from
Jun 14, 2024

Conversation

rocketnova
Copy link
Contributor

Ticket

  • N/A

Changes

What was added, updated, or removed in this PR.

  • Updates Dockerfile to install wget for the release target

Context for reviewers

Background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers.

wget is used by default for the infrastructure template ELB healthcheck. This PR adds wget to the production release image.

Testing

Provide testing instructions and evidence that the code works as expected. Include screenshots, GIF demos, shell commands or output to help show the changes working as expected. ProTip: you can drag and drop or paste images into this textbox.

Test this PR by using the mock-production docker compose:

  1. Checkout this branch: git checkout rocket/install-wget
  2. Change to the application directory: cd app-rails
  3. Initialize the container: make init-container DOCKER_COMPOSE_ARGS="-f ../docker-compose.mock-production.yml"
  4. Fill in the .env details in /app-rails/.env
    • You must do this otherwise the container won't start correctly.
  5. Start the container: make start-container DOCKER_COMPOSE_ARGS="-f ../docker-compose.mock-production.yml"
  6. In another terminal window, start a shell in the container: docker compose -f ../docker-compose.mock-production.yml exec app-rails bash
  7. Use which to verify that wget is installed. For example:
    • CleanShot 2024-06-14 at 13 50 29@2x

@rocketnova rocketnova merged commit 8cafc7f into main Jun 14, 2024
5 checks passed
@rocketnova rocketnova deleted the rocket/install-wget branch June 14, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants