Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rubocop settings #27

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Update Rubocop settings #27

merged 1 commit into from
Jun 10, 2024

Conversation

ellery-nava
Copy link
Contributor

Ticket

Changes

Update Rubocop config to target specific Ruby version (should help narrow down a couple of style rules)
Remove exclusion for directory that does not exist in this template

Context for reviewers

Read Rubocop docs, could not find any other configuration that we would need for this template
Already have configuration for both Rails and rspec with no overrides currently (rubocop-rails-omakase, rubocop-rspec)

Testing

Ran linter, no issues found

rocketnova
rocketnova approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@rocketnova rocketnova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ellery-nava ellery-nava merged commit a18946b into main Jun 10, 2024
5 checks passed
@ellery-nava ellery-nava deleted the eroyston/rubocop-updates branch June 10, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rocketnova rocketnova rocketnova approved these changes

@SammySteiner SammySteiner Awaiting requested review from SammySteiner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply rspec style guide Apply rails style guide Apply ruby style guide
2 participants
@ellery-nava @rocketnova