Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce prettier overrides #30

Merged
merged 2 commits into from
Sep 29, 2022
Merged

Reduce prettier overrides #30

merged 2 commits into from
Sep 29, 2022

Conversation

jimmyfagan
Copy link
Contributor

Ticket

#24

Changes

This PR removed some non-default settings for prettier and then also made the formatting changes associated with that setting change. The setting change and the format change are in separate commits, in case that makes it easier to review.

Context for reviewers

All changes should be non-functional, so just visual confirmation that this looks right is probably all that's needed. Rationale for the change is provided in the issue (#24).

Testing

Non-functional changes, so little testing was needed, but I still ran storybook and the next.js app to make sure those still work, and they did.

@jimmyfagan jimmyfagan merged commit 3abec8e into main Sep 29, 2022
@jimmyfagan jimmyfagan deleted the jimmy/prettier branch September 29, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants