Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to latest LTS node version (20) #294

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Upgrade to latest LTS node version (20) #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
741ad2b
Upgrade to latest LTS node version
sawyerh Jan 31, 2024
4b49314
Merge branch 'main' of github.com:navapbc/template-application-nextjs…
sawyerh Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cd-storybook.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: 18
node-version: 20
cache-dependency-path: ./app/package-lock.json # or yarn.lock
cache: npm # or yarn
- name: Setup Pages
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-app.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ defaults:
working-directory: ./app

env:
NODE_VERSION: 18
NODE_VERSION: 20
LOCKFILE_PATH: ./app/package-lock.json # or yarn.lock
PACKAGE_MANAGER: npm # or yarn

Expand Down
4 changes: 2 additions & 2 deletions app/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# This file is largely based on the template-application-flask Dockerfile and
# Next.js Docker example: https://github.com/vercel/next.js/blob/canary/examples/with-docker-compose
# =============================================================================
FROM node:18.19.0-bullseye-slim AS base
FROM node:20.11.0-bullseye-slim AS base
WORKDIR /app

# Install dependencies
Expand Down Expand Up @@ -56,7 +56,7 @@ RUN npm run build -- --no-lint
# Run the Next.js server
# =====================================
# Use clean image for release, excluding any unnecessary files or dependencies
FROM node:18.19.0-bullseye-slim AS release
FROM node:20.11.0-bullseye-slim AS release
WORKDIR /app

RUN apt-get update \
Expand Down
Loading