Add ADR for enabling i18n type checking #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sawyerh
commented
Aug 29, 2023
| # Enable i18next type checks | ||
|
|
||
| - Status: proposed | ||
| - Deciders: [list everyone involved in the decision] <!-- optional --> |
|
thought: idea (or maybe suggestion?) i wonder if it would make sense to mention something about handling content that's managed outside the codebase e.g. an external translation service. even if we don't architect for that immediately, could still be helpful to link to a reference like this one https://dev.to/adrai/supercharge-your-typescript-app-mastering-i18next-for-type-safe-translations-2idp that explains how that might be done if a project ends up needing to do that before it's supported out of the box in the template |
sawyerh
commented
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Relates to #194
Context for reviewers
An implementation can be seen at #199