Upgrade to Storybook V7 #160
Conversation
There was a problem hiding this comment.
I'm mostly driving by here, but this lgtm other than 1 comment. I tried finding a solution to the postcss issue for NJ also but couldn't figure it out. I'll defer to folks more involved in this project / you on if those icons that render strangely is blocking. Seems like we'll have to deal with it anyway until there is a fix.
| // Support deploying Storybook to a subdirectory (like GitHub Pages). | ||
| // This makes the Storybook JS bundles load correctly. | ||
| if (NEXT_PUBLIC_BASE_PATH) { | ||
| config.output = config.output ?? {}; | ||
| config.output.publicPath = `${NEXT_PUBLIC_BASE_PATH}/`; | ||
| } | ||
|
|
||
| return config; |
There was a problem hiding this comment.
❓ Did you intend on removing this -- would this cause issues with deploying to github pages w/o it?
There was a problem hiding this comment.
Yeah, it seems like the Next.js Storybook framework integration now does all of this for us. I tested deploying this branch to GitHub Pages and it works: https://navapbc.github.io/template-application-nextjs/
|
|
||
| export const Home = Template.bind({}); | ||
| export const Preview = {}; |
There was a problem hiding this comment.
markup seems a lot cleaner with this new format!
|
This may be helpful for future folks - but if you have many stories in your repo, storybook provides a codemod to automatically convert CSF2 -> CSF3 https://storybook.js.org/docs/react/migration-guide#csf2-to-csf3 You may have to update some of your stories manually, so keep that in mind. |
|
@brandon-lent going forward don't be afraid to approve PRs too, you know more react than i do and are more hands on with it too. i don't need to be a bottleneck |
|
oh nvm you did approve it lol. haha i misread the github notification sorry! |
|
Looks like you can install the plugin recommended from storybook to fix the icon issue, not sure if you wanted to experiment with that in this PR or a separate one |
Ticket
Changes
Testing