Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix links to docker-compose.yml #233

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Fix links to docker-compose.yml #233

merged 1 commit into from
Jul 5, 2024

Conversation

KevinJBoyer
Copy link
Contributor

Ticket

n/a

Changes

  • Add support for local secrets #227 moved the docker-compose.yml file out of the root and into /app, but missed updating links to it in the documentation. This updates those links.

Context for reviewers

n/a

Testing

n/a

@KevinJBoyer KevinJBoyer requested a review from lorenyu July 5, 2024 19:39
lorenyu
lorenyu reviewed Jul 5, 2024
View reviewed changes
Copy link
Contributor

@lorenyu lorenyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I normally prefer absolute paths for doc links but in this case I feel like relative paths are simpler since a project team might rename the app folder.

lorenyu
lorenyu approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@lorenyu lorenyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see previous comment but will approve for now to avoid an extra back and forth

@lorenyu
Copy link
Contributor

lorenyu commented Jul 5, 2024

nvm i realize what i was suggesting isn't possible, feel free to merge as is

@KevinJBoyer KevinJBoyer merged commit dded29c into main Jul 5, 2024
@KevinJBoyer KevinJBoyer deleted the kb/fix-links branch July 5, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorenyu lorenyu lorenyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KevinJBoyer @lorenyu