Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Pydantic version #209

Merged
merged 5 commits into from
Oct 13, 2023
Merged

Upgrade Pydantic version #209

merged 5 commits into from
Oct 13, 2023

Conversation

chouinar
Copy link
Contributor

Ticket

#208

Changes

Upgrades to Pydantic v2

Context for reviewers

https://docs.pydantic.dev/latest/migration/

Pydantic v2 is a fairly large rewrite of the library, although the template only relies on it for env-var management. v2 is getting updated consistently and is actively being worked on.

Testing

make format lint test all work both running outside the Docker container and within it.

@chouinar chouinar changed the title Chouinar/upgrade pydantic Upgrade Pydantic version Oct 11, 2023
Copy link

@jayreed-nava jayreed-nava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had no issues getting the template up and running with these changes
LGTM

@chouinar chouinar merged commit e48e359 into main Oct 13, 2023
4 checks passed
@chouinar chouinar deleted the chouinar/upgrade-pydantic branch October 13, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants