Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update breaking internal links #110

Merged
merged 1 commit into from
Jan 31, 2023
Merged

update breaking internal links #110

merged 1 commit into from
Jan 31, 2023

Conversation

lxqnt
Copy link
Contributor

@lxqnt lxqnt commented Jan 28, 2023

Ticket

No ticket

Changes

Updates several internal links within markdown files and some comments that were previously broken.

Context for reviewers

Testing

manual testing

@lxqnt lxqnt requested a review from lorenyu January 28, 2023 02:30
lorenyu
lorenyu approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@lorenyu lorenyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these fixes!

btw when filling out the PR template, it's ok to remove the block quote formatting, so the text can be something

Context for reviewers

did something

as opposed to

Context for reviewers

did something

@lxqnt lxqnt merged commit e0d676a into main Jan 31, 2023
@lxqnt lxqnt deleted the lexiquint/readme-links branch January 31, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorenyu lorenyu lorenyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lxqnt @lorenyu