Update Docker Image to Ubuntu 22.04 #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanculver
reviewed
May 24, 2023
| @@ -36,7 +36,7 @@ RUN apt-get update -y && \ | |||
| ln -fs /usr/share/zoneinfo/UTC /etc/localtime && \ | |||
| dpkg-reconfigure -f noninteractive tzdata && \ | |||
| apt-get install -y python3 python3-psycopg2 python3-pip \ | |||
| python3-venv python3-dev python3-apt postgresql-12 \ | |||
| python3-venv python3-dev python3-apt postgresql-14 \ | |||
There was a problem hiding this comment.
I think this might be an issue since we have issue with using postgres14 on ARM (psycopg hasn't shipped an 14 compatible binary for ARM arch)
There was a problem hiding this comment.
@bryanculver I tested the build and a basic run on my M1 MBP this morning. Are there additional tests that I should perform?
There was a problem hiding this comment.
I just checked this not too long ago today and forgot to follow up. Since my PR many moons ago to psycopg it looks like they have updated. 👍
There was a problem hiding this comment.
Sorry I had forgotten to follow up to my original comment.
bryanculver
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #61
In my testing, bumping up to Ubuntu 22.04 in the docker image resolves the issue with building on the Apple ARM architecture.